Review 61ecf250c4b4

#!/bin/sh
set -eu
d=$(mktemp -d ./review-dedupe-XXXXXX)
trap 'rm -rf "$d"' EXIT HUP INT TERM
cat > "$d/main.go" <<'GO'
package main
import (
 "context"
 "fmt"
 "os"
 "strings"
 "time"
 a "github.com/pdbethke/corralai/internal/adequacy"
)
func must(err error) { if err != nil { panic(err) } }
func main() {
 root, err := os.MkdirTemp(".", "review-suite-"); must(err)
 defer os.RemoveAll(root)
 j := a.NewWorkspaceRunner(root, time.Second)
 strict := []string{"sh", "-c", "set -e; . ./value.sh; test \"$v\" -eq 1"}
 loose := []string{"sh", "-c", "set -e; . ./value.sh; test \"$v\" -ge 1"}
 mutants := []a.Mutant{
  {ID:"strict", Search:"v=1", Replace:"v=2"},
  {ID:"loose", Search:"v=1", Replace:"v=2"},
 }
 selectCmd := a.WithCommandFor(func(m a.Mutant) a.MutantCommand {
  if m.ID == "loose" { return a.MutantCommand{Cmd:loose, Tests:1} }
  return a.MutantCommand{Cmd:strict, Tests:1}
 })
 control, err := a.Score(context.Background(), j, nil, "value.sh", "v=1\n", mutants[1:], strict, selectCmd); must(err)
 combined, err := a.Score(context.Background(), j, nil, "value.sh", "v=1\n", mutants, strict, selectCmd); must(err)
 fmt.Printf("loose mutant alone: killed=%v survived=%v\n", control.Killed, control.Survived)
 fmt.Printf("same mutant beside identical strict mutant: killed=%v survived=%v duplicates=%d\n", combined.Killed, combined.Survived, combined.DuplicateMutants)
 if !control.CompliantPass || !control.CanaryKilled || strings.Join(control.Survived, ",") != "loose" || len(control.Killed) != 0 { os.Exit(1) }
 if !combined.CompliantPass || !combined.CanaryKilled || strings.Join(combined.Killed, ",") != "strict,loose" || len(combined.Survived) != 0 || combined.DuplicateMutants != 1 { os.Exit(1) }
 fmt.Println("DEFECT: the selected command survives this mutant, but deduplication reports it killed.")
}
GO
GOPROXY=off GOSUMDB=off GOTOOLCHAIN=local timeout 55s go run "$d"

loose mutant alone: killed=[] survived=[loose]
same mutant beside identical strict mutant: killed=[strict loose] survived=[] duplicates=1
DEFECT: the selected command survives this mutant, but deduplication reports it killed.

#!/bin/sh
set -eu
d=$(mktemp -d ./review-symlink-XXXXXX)
trap 'rm -rf "$d"' EXIT HUP INT TERM
cat > "$d/main.go" <<'GO'
package main
import (
 "context"
 "fmt"
 "os"
 "path/filepath"
 "time"
 a "github.com/pdbethke/corralai/internal/adequacy"
)
func must(err error) { if err != nil { panic(err) } }
func main() {
 root, err := os.MkdirTemp(".", "review-workspace-"); must(err)
 defer os.RemoveAll(root)
 link := filepath.Join(root, "source.txt")
 target := filepath.Join(root, "target.txt")
 must(os.Symlink("target.txt", link))
 before, err := os.Readlink(link); must(err)
 if _, err := os.Lstat(target); !os.IsNotExist(err) { panic("target must initially be absent") }
 fmt.Printf("before: source.txt -> %s; target.txt absent\n", before)
 j := a.NewWorkspaceRunner(root, time.Second)
 passed, runErr := j.RunTest(context.Background(), map[string]string{"source.txt":"MUTANT\n"}, []string{"sh", "-c", "test \"$(cat source.txt)\" = MUTANT"})
 _, linkErr := os.Lstat(link)
 content, targetErr := os.ReadFile(target)
 fmt.Printf("after: passed=%v error=%v symlinkAbsent=%v target=%q targetError=%v\n", passed, runErr, os.IsNotExist(linkErr), content, targetErr)
 if !passed || runErr != nil || !os.IsNotExist(linkErr) || targetErr != nil || string(content) != "MUTANT\n" { os.Exit(1) }
 fmt.Println("DEFECT: a read-only test command returned successfully, but restoration deleted the original symlink and retained mutant bytes.")
}
GO
GOPROXY=off GOSUMDB=off GOTOOLCHAIN=local timeout 55s go run "$d"

before: source.txt -> target.txt; target.txt absent
after: passed=true error=<nil> symlinkAbsent=true target="MUTANT\n" targetError=<nil>
DEFECT: a read-only test command returned successfully, but restoration deleted the original symlink and retained mutant bytes.